Skip to content

feat(GlFilteredSearch): Add suggestionsListClass to suggestions list

What does this MR do?

This MR adds a suggestionsListClass to the filter search suggestions dropdown. This way, we can easily add allow users to add custom CSS classes to the dropdown. We recently noticed chart tooltips getting into its way in several places, for example see gitlab#280811 (closed)

This issue can be solved by adding a custom CSS class with a high z-index to the dropdown.

mr_analytics_dropdown_tooltip_overlap

Does this MR meet the acceptance criteria?

Conformity

  • Code review guidelines.
  • GitLab UI's contributing guidlines.
  • If it changes a Pajamas-compliant component's look & feel, the MR has been reviewed by a UX designer.
  • If it changes GitLab UI's documentation guidelines, the MR has been reviewed by a Technical Writer.
  • If the MR changes a component's API, integration MR(s) have been opened in the following projects to ensure that the @gitlab/ui package can be upgraded quickly after the changes are released:
  • Added the ~"component:*" label(s) if applicable.

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Martin Wortschack

Merge request reports

Loading