Skip to content

Fix popover audit issue

Jarek Ostrowski requested to merge fix-popover-audit-issue into master

What does this MR do?

Adjusts GlPopover to bring parity with our Figma styles, based on our popover audit issue.

Integration MR: gitlab!48910 (merged)

Before After
Screen_Shot_2020-11-23_at_3.29.13_PM Screen_Shot_2020-11-23_at_3.30.12_PM
Screen_Shot_2020-11-23_at_3.29.30_PM Screen_Shot_2020-11-23_at_3.30.05_PM
Screen_Shot_2020-11-23_at_3.29.36_PM Screen_Shot_2020-11-23_at_3.29.58_PM)
Screen_Shot_2020-11-23_at_3.29.42_PM Screen_Shot_2020-11-23_at_3.29.51_PM

Does this MR meet the acceptance criteria?

Conformity

  • Code review guidelines.
  • GitLab UI's contributing guidlines.
  • If it changes a Pajamas-compliant component's look & feel, the MR has been reviewed by a UX designer.
  • If it changes GitLab UI's documentation guidelines, the MR has been reviewed by a Technical Writer.
  • If the MR changes a component's API, integration MR(s) have been opened in the following projects to ensure that the @gitlab/ui package can be upgraded quickly after the changes are released:
  • Added the ~"component:*" label(s) if applicable.

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Jarek Ostrowski

Merge request reports

Loading