Skip to content

fix: Add focus state to toggle and clear icon button

Coung Ngo requested to merge cngo-add-toggle-and-clear-button-focus into master

What does this MR do?

This MR adds visual focus to the toggle and clear icon button elements for tab accessibility. It also removes a CSS outline value for the badge component which is unnecessary since it is not focusable.

Screenshots

Screen_Recording_2020-11-26_at_5.22.29_pm

Screenshot_2020-11-26_at_5.22.58_pm

Does this MR meet the acceptance criteria?

Conformity

  • Code review guidelines.
  • GitLab UI's contributing guidlines.
  • If it changes a Pajamas-compliant component's look & feel, the MR has been reviewed by a UX designer.
  • If it changes GitLab UI's documentation guidelines, the MR has been reviewed by a Technical Writer.
  • If the MR changes a component's API, integration MR(s) have been opened in the following projects to ensure that the @gitlab/ui package can be upgraded quickly after the changes are released:
  • Added the ~"component:*" label(s) if applicable.

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • Security reports checked/validated by a reviewer from the AppSec team

Merge request reports

Loading