Skip to content

Document right dropdown alignment property

Mike Greiling requested to merge mg-document-right-aligned-dropdown into master

What does this MR do?

The right prop of gl-dropdown already existed as a pass-through option to b-dropdown, but it was not obvious that this could be utilized as it is not documented explicitly in our storybook page and in the pajamas examples. Adding this should boost the visibility of this option a bit.

Does this MR meet the acceptance criteria?

Conformity

  • Code review guidelines.
  • GitLab UI's contributing guidlines.
  • If it changes a Pajamas-compliant component's look & feel, the MR has been reviewed by a UX designer.
  • If it changes GitLab UI's documentation guidelines, the MR has been reviewed by a Technical Writer.
  • If the MR changes a component's API, integration MR(s) have been opened in the following projects to ensure that the @gitlab/ui package can be upgraded quickly after the changes are released:
  • Added the ~"component:*" label(s) if applicable.

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • Security reports checked/validated by a reviewer from the AppSec team

closes #999 (closed)

Merge request reports

Loading