Skip to content

Remove title from empty state illustration

Coung Ngo requested to merge 739-remove-title-from-empty-state-illustration into master

What does this MR do?

The empty state title is used as the value for both the empty state illustration alt and the h1 element. This results in repeated information to screen readers, which this MR fixes.

Accessibility tree before and after:

before after
Screenshot_2021-01-07_at_6.25.23_pm Screenshot_2021-01-08_at_5.41.48_pm

Does this MR meet the acceptance criteria?

Conformity

  • Code review guidelines.
  • GitLab UI's contributing guidlines.
  • If it changes a Pajamas-compliant component's look & feel, the MR has been reviewed by a UX designer.
  • If it changes GitLab UI's documentation guidelines, the MR has been reviewed by a Technical Writer.
  • If the MR changes a component's API, integration MR(s) have been opened in the following projects to ensure that the @gitlab/ui package can be upgraded quickly after the changes are released:
  • Added the ~"component:*" label(s) if applicable.

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • Security reports checked/validated by a reviewer from the AppSec team

Closes #739 (closed)

Edited by Coung Ngo

Merge request reports

Loading