Skip to content

feat(GlSingleStat): Restyle and enhance component

Brandon Labuschagne requested to merge feat-gl-single-stat-major-update into master

What does this MR do?

The MR restyles the GlSingleStat component from the ground up.

It also exposes additional props in order to display more information.

Before After With unit and meta icon and meta badge and title icon
Screenshot_2021-01-11_at_14.39.09 Screenshot_2021-01-12_at_15.19.31 Screenshot_2021-01-12_at_15.19.49 Screenshot_2021-01-12_at_15.21.33 Screenshot_2021-01-12_at_15.22.11 Screenshot_2021-01-12_at_15.22.41

Does this MR meet the acceptance criteria?

Conformity

  • Code review guidelines.
  • GitLab UI's contributing guidlines.
  • If it changes a Pajamas-compliant component's look & feel, the MR has been reviewed by a UX designer.
  • If it changes GitLab UI's documentation guidelines, the MR has been reviewed by a Technical Writer.
  • If the MR changes a component's API, integration MR(s) have been opened in the following projects to ensure that the @gitlab/ui package can be upgraded quickly after the changes are released:
  • Added the ~"component:*" label(s) if applicable.

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • Security reports checked/validated by a reviewer from the AppSec team

Related to issue #1086 (closed)

Edited by Brandon Labuschagne

Merge request reports

Loading