Skip to content

feat: use gitlab-svgs in stories

Adriel Santiago requested to merge adriel-use-svgs-in-stories into master

Thus far we have been passing needed svg path data (for echarts for example) as a prop to our various charting components. This strategy keeps us from having to add gitlab-svgs as a dependency for gitlab-ui until #98 (closed) is addressed. In the meantime we've had to hardcode the svg data information for our storybook snapshots -- which is not as maintainable as simply staying up to date with @gitlab/svgs.

This merge request:

  • allows for gitlab-svg usage within storybook by adding @gitlab/svgs as a dev dependency.
  • replaces existing hard-coded svg path data using some new path content retrieval helpers.
Edited by Adriel Santiago

Merge request reports