Skip to content

chore: update hierarchy separators

Paul Gascou-Vaillancourt requested to merge update-hierarchy-separator into master

What does this MR do?

In Storybook 6, | and . hierarchy separator aren't supported anymore, so it's advised to replace them all with /, which is what this MR does. This slightly changes how the sidebar renders, but other than, everything works the same. Most importantly, all paths are the same.

Before After
Screen_Shot_2021-01-15_at_6.50.13_AM Screen_Shot_2021-01-15_at_6.50.21_AM

Does this MR meet the acceptance criteria?

Conformity

  • Code review guidelines.
  • GitLab UI's contributing guidlines.
  • If it changes a Pajamas-compliant component's look & feel, the MR has been reviewed by a UX designer.
  • If it changes GitLab UI's documentation guidelines, the MR has been reviewed by a Technical Writer.
  • If the MR changes a component's API, integration MR(s) have been opened in the following projects to ensure that the @gitlab/ui package can be upgraded quickly after the changes are released:
  • Added the ~"component:*" label(s) if applicable.

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Paul Gascou-Vaillancourt

Merge request reports

Loading