Skip to content

fix: set color for .gl-avatar-labeled

Tom Quirk requested to merge tomquirk-set-avatar-labelled-as-one-color into main

What does this MR do?

If the meta slot of GlAvatarLabeled is a link, the hover state is blue, which feels inconsistent to the rest of this component.

This MR explicitly sets the color of the entire component, which resolves the issue. The onus of customizing the hover state (and other styling) of the meta tag is now entirely on the developer using GlAvatarLabeled.

This came up while implementing gitlab!53806 (diffs) (as part of gitlab#298724 (closed))

Before After
Screen_Shot_2021-02-10_at_3.34.15_pm Screen_Shot_2021-02-10_at_3.30.44_pm

Does this MR meet the acceptance criteria?

Conformity

  • Code review guidelines.
  • GitLab UI's contributing guidlines.
  • If it changes a Pajamas-compliant component's look & feel, the MR has been reviewed by a UX designer.
  • If it changes GitLab UI's documentation guidelines, the MR has been reviewed by a Technical Writer.
  • If the MR changes a component's API, integration MR(s) have been opened in the following projects to ensure that the @gitlab/ui package can be upgraded quickly after the changes are released:
  • Added the ~"component:*" label(s) if applicable.

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • Security reports checked/validated by a reviewer from the AppSec team

Accessibility

If this MR adds or modifies a component, take a few moments to review the following:

  • All actions and functionality can be done with a keyboard.
  • Links, buttons, and controls have a visible focus state.
  • All content is presented in text or with a text equivalent. For example, alt text for SVG, or aria-label for icons that have meaning or perform actions.
  • Changes in a component’s state are announced by a screen reader. For example, changing aria-expanded="false" to aria-expanded="true" when an accordion is expanded.
  • Color combinations have sufficient contrast.
Edited by Tom Quirk

Merge request reports

Loading