Skip to content

fix(GlForm): Fix resting state color

Md. Pial Ahamed requested to merge (removed):1355-form-inputs-validation-correct-resting-state into main

What does this MR do?

This MR has done as a part of https://gitlab.com/gitlab-com/marketing/community-relations/contributor-program/hackathon/-/issues/50

Currently when our form field is invalid red-500 color shows in all states. Currently, we don't have any mixin for red-400, so I have added it in box-shadow.css. After adding red-400 hover color also change to red-400 as there is no logic for hover currently. As both focus and hover have the same property, added hover along with focus.

State Preview
Current image
This MR image

Does this MR meet the acceptance criteria?

Conformity

  • Code review guidelines.
  • GitLab UI's contributing guidlines.
  • If it changes a Pajamas-compliant component's look & feel, the MR has been reviewed by a UX designer.
  • If it changes GitLab UI's documentation guidelines, the MR has been reviewed by a Technical Writer.
  • If the MR changes a component's API, integration MR(s) have been opened in the following projects to ensure that the @gitlab/ui package can be upgraded quickly after the changes are released:
  • Added the ~"component:*" label(s) if applicable.

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • Security reports checked/validated by a reviewer from the AppSec team

Accessibility

If this MR adds or modifies a component, take a few moments to review the following:

  • All actions and functionality can be done with a keyboard.
  • Links, buttons, and controls have a visible focus state.
  • All content is presented in text or with a text equivalent. For example, alt text for SVG, or aria-label for icons that have meaning or perform actions.
  • Changes in a component’s state are announced by a screen reader. For example, changing aria-expanded="false" to aria-expanded="true" when an accordion is expanded.
  • Color combinations have sufficient contrast.

Closes #1355 (closed)

Merge request reports