Skip to content

feat(GlTokenSelector): add `state` prop for validation

What does this MR do?

Closes #1374 (closed)

Needed for https://gitlab.com/gitlab-org/gitlab/-/issues/325147#note_555414572

Due to this issue the state prop on GlFormGroup does not work for GlTokenSelector. This is because Bootstrap uses a CSS sibling selector to correctly style form inputs. But when the input has complicated nesting (like GlTokenSelector) this doesn't work correctly. The workaround is to use the state prop as described in https://github.com/bootstrap-vue/bootstrap-vue/issues/1251#issuecomment-340067065.

This MR adds a state prop that works the same way as the Bootstrap Vue Form Input state prop \

Screenshots

State
Normal Screen_Shot_2021-04-23_at_12.08.51_PM
Invalid Screen_Shot_2021-04-23_at_12.09.06_PM

Does this MR meet the acceptance criteria?

Conformity

  • Code review guidelines.
  • GitLab UI's contributing guidlines.
  • If it changes a Pajamas-compliant component's look & feel, the MR has been reviewed by a UX designer.
  • If it changes GitLab UI's documentation guidelines, the MR has been reviewed by a Technical Writer.
  • If the MR changes a component's API, integration MR(s) have been opened in the following projects to ensure that the @gitlab/ui package can be upgraded quickly after the changes are released:
  • Added the ~"component:*" label(s) if applicable.

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] Security reports checked/validated by a reviewer from the AppSec team

Accessibility

If this MR adds or modifies a component, take a few moments to review the following:

  • All actions and functionality can be done with a keyboard.
  • Links, buttons, and controls have a visible focus state.
  • All content is presented in text or with a text equivalent. For example, alt text for SVG, or aria-label for icons that have meaning or perform actions.
  • Changes in a component’s state are announced by a screen reader. For example, changing aria-expanded="false" to aria-expanded="true" when an accordion is expanded.
  • Color combinations have sufficient contrast.
Edited by Peter Hegman

Merge request reports

Loading