fix(GlSafeLinkDirective): pass arguments to `update` hook
What does this MR do?
Related to gitlab#331355 (closed)
In !2191 (merged) we added v-safe-html
to GlButton
but there is an issue with v-safe-html
where the skipSanitization
argument is not respected in the update
hook. This is because the binding
argument is not passed to the update
hook.
Currently this bug is affecting the "Download codes" button in the 2FA setup flow, but it may be affecting other parts of the codebase.
Before | After |
---|---|
Screen_Recording_2021-06-28_at_12.55.59_PM | Screen_Recording_2021-06-28_at_1.18.02_PM |
Does this MR meet the acceptance criteria?
Conformity
-
Code review guidelines. -
GitLab UI's contributing guidlines. - [-] If it changes a Pajamas-compliant component's look & feel, the MR has been reviewed by a UX designer.
- [-] If it changes GitLab UI's documentation guidelines, the MR has been reviewed by a Technical Writer.
-
If the MR changes a component's API, integration MR(s) have been opened in the following projects to ensure that the @gitlab/ui
package can be upgraded quickly after the changes are released: -
Added the ~"component:*"
label(s) if applicable.
Edited by Peter Hegman