Skip to content

feat(Tabs): Badge counter should use SR only

Jeremy Elder requested to merge 1574-tabs-badge-counter-should-use-sr-only into main

What does this MR do?

Adds sr-only text to badge counters so that the count can be more clear. This change is mirrored in Pajamas in gitlab-org/gitlab-services/design.gitlab.com!2586 (diffs).

This is based on the button example that also includes a badge with sr-only text https://gitlab-org.gitlab.io/gitlab-ui/?path=/docs/base-button--badge-with-sr-only-text.

Does this MR meet the acceptance criteria?

Conformity

  • Code review guidelines.
  • GitLab UI's contributing guidlines.
  • If it changes a Pajamas-compliant component's look & feel, the MR has been reviewed by a UX designer.
  • If it changes GitLab UI's documentation guidelines, the MR has been reviewed by a Technical Writer.
  • If the MR changes a component's API, integration MR(s) have been opened in the following projects to ensure that the @gitlab/ui package can be upgraded quickly after the changes are released:
  • Added the ~"component:*" label(s) if applicable.

Security

N/A

Accessibility

If this MR adds or modifies a component, take a few moments to review the following:

  • All actions and functionality can be done with a keyboard.
  • Links, buttons, and controls have a visible focus state.
  • All content is presented in text or with a text equivalent. For example, alt text for SVG, or aria-label for icons that have meaning or perform actions.
  • Changes in a component’s state are announced by a screen reader. For example, changing aria-expanded="false" to aria-expanded="true" when an accordion is expanded.
  • Color combinations have sufficient contrast.

Closes #1574

Edited by Jeremy Elder

Merge request reports

Loading