Skip to content

perf(GLTable): Enhance GlTable to render b-table-lite when possible

Jannik Lehmann requested to merge jnnkl-gltable-enhancement into main

What does this MR do?

UPDATE: This MR was closed because of too many conflicts between the way this MR treats dynamic imports and Issues in our current codebase. Further progress on enhancing the GlTable component will be tracked in this epic.

This MR solves: #1593 (closed)

  • It enhances the GlTable component to, depending on the given slots and props render BTable or BTableLite.

  • It removes the GlTableLite component, which is a breaking change to GitLabUI.

  • GlTable does now import BTable or BTableLite dynamically depending on its input.

Integration MR: gitlab!73462 (closed)

Bundle Analysis from Integration MR: https://gitlab-org.gitlab.io/-/gitlab/-/jobs/1735201072/artifacts/bundle-size-review/comparison.html

screen, no visual changes
Screenshot_2021-10-22_at_16.50.20

Does this MR meet the acceptance criteria?

Conformity

  • Code review guidelines.
  • GitLab UI's contributing guidlines.
  • If it changes a Pajamas-compliant component's look & feel, the MR has been reviewed by a UX designer.
  • If it changes GitLab UI's documentation guidelines, the MR has been reviewed by a Technical Writer.
  • If the MR changes a component's API, integration MR(s) have been opened in the following projects to ensure that the @gitlab/ui package can be upgraded quickly after the changes are released:
  • Added the ~"component:*" label(s) if applicable.

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • Security reports checked/validated by a reviewer from the AppSec team

Accessibility

If this MR adds or modifies a component, take a few moments to review the following:

  • All actions and functionality can be done with a keyboard.
  • Links, buttons, and controls have a visible focus state.
  • All content is presented in text or with a text equivalent. For example, alt text for SVG, or aria-label for icons that have meaning or perform actions.
  • Changes in a component’s state are announced by a screen reader. For example, changing aria-expanded="false" to aria-expanded="true" when an accordion is expanded.
  • Color combinations have sufficient contrast.
Edited by Jannik Lehmann

Merge request reports

Loading