Skip to content

feat(GlTruncate): show full text in a tooltip

Paul Gascou-Vaillancourt requested to merge gl-truncate-tooltip into main

What does this MR do?

This MR does the following improvements:

  • f776eaed: GlTruncate now accepts a withTooltip prop. When enabled, a tooltip containing the full text is attached to the component only if the text is being truncated.
  • 2a63e048: Moves the POSITION constant out of the data method as it does not need to be reactive.
  • dd7768d3: GlResizeObserverDirective now accepts an argument to turn the observer on or off. We use this to prevent attaching an observer unnecessarily in GlTruncate when withTooltip is disabled.
  • 6b010038: We now expose Cypress' results as a job artifact when integration tests fail in CI. This can help with debugging.

These changes are being integrated in gitlab!73641 (merged).

Does this MR meet the acceptance criteria?

Conformity

  • Code review guidelines.
  • GitLab UI's contributing guidlines.
  • If it changes a Pajamas-compliant component's look & feel, the MR has been reviewed by a UX designer.
  • If it changes GitLab UI's documentation guidelines, the MR has been reviewed by a Technical Writer.
  • If the MR changes a component's API, integration MR(s) have been opened in the following projects to ensure that the @gitlab/ui package can be upgraded quickly after the changes are released:
  • Added the ~"component:*" label(s) if applicable.

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • Security reports checked/validated by a reviewer from the AppSec team

Accessibility

If this MR adds or modifies a component, take a few moments to review the following:

  • All actions and functionality can be done with a keyboard.
  • Links, buttons, and controls have a visible focus state.
  • All content is presented in text or with a text equivalent. For example, alt text for SVG, or aria-label for icons that have meaning or perform actions.
  • Changes in a component’s state are announced by a screen reader. For example, changing aria-expanded="false" to aria-expanded="true" when an accordion is expanded.
  • Color combinations have sufficient contrast.
Edited by Paul Gascou-Vaillancourt

Merge request reports