Skip to content

feat(GlChart): Addition of GlResizeObserverDirective for charts

What does this MR do?

This merge request contains the changes where GlResizeObserverDirective is added to charts by default and makes the chart responsive.

Testing

Confirmation that this MR does not break existing charts in the gitlab project that are currently wrapped with GlResizeObserverDirective - tested resizing these charts.

File path (shortened) Screenshot
contribution_analytics/components/column_chart.vue Screenshot_2021-12-09_at_17.46.12
burndown_chart/components/burndown_chart.vue Screenshot_2021-12-09_at_17.49.39
devops_adoption_overview_chart.vue Screenshot_2021-12-09_at_17.36.57

Does this MR meet the acceptance criteria?

Conformity

  • Code review guidelines.
  • GitLab UI's contributing guidlines.
  • If it changes a Pajamas-compliant component's look & feel, the MR has been reviewed by a UX designer.
  • If it changes GitLab UI's documentation guidelines, the MR has been reviewed by a Technical Writer.
  • If the MR changes a component's API, integration MR(s) have been opened in the following projects to ensure that the @gitlab/ui package can be upgraded quickly after the changes are released:
  • Added the ~"component:*" label(s) if applicable.

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • Security reports checked/validated by a reviewer from the AppSec team

Accessibility

If this MR adds or modifies a component, take a few moments to review the following:

  • All actions and functionality can be done with a keyboard.
  • Links, buttons, and controls have a visible focus state.
  • All content is presented in text or with a text equivalent. For example, alt text for SVG, or aria-label for icons that have meaning or perform actions.
  • Changes in a component’s state are announced by a screen reader. For example, changing aria-expanded="false" to aria-expanded="true" when an accordion is expanded.
  • Color combinations have sufficient contrast.

Related issue

#1570 (closed)

Edited by Brandon Labuschagne

Merge request reports

Loading