Skip to content

fix(GlBreadcrumb): update breadcrumb's item avatar styles

Olena Horal-Koretska requested to merge 1581-correct-breadcrumb-avatar-size into main

What does this MR do?

  • Change avatar's border radius to be 4px
  • Update the docs to use the correct image size example
  • Sets role="presentation" on the avatar's image (I think it serves a merely presentational purpose, but we can discuss this). This change was due to storybook's accessibility addon error. We might set the alt text on the image instead.

Screenshot_2022-01-06_at_14.02.09

Does this MR meet the acceptance criteria?

Conformity

  • Code review guidelines.
  • GitLab UI's contributing guidlines.
  • If it changes a Pajamas-compliant component's look & feel, the MR has been reviewed by a UX designer.
  • If it changes GitLab UI's documentation guidelines, the MR has been reviewed by a Technical Writer.
  • If the MR changes a component's API, integration MR(s) have been opened in the following projects to ensure that the @gitlab/ui package can be upgraded quickly after the changes are released:
  • Added the ~"component:*" label(s) if applicable.

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • Security reports checked/validated by a reviewer from the AppSec team

Accessibility

If this MR adds or modifies a component, take a few moments to review the following:

  • All actions and functionality can be done with a keyboard.
  • Links, buttons, and controls have a visible focus state.
  • All content is presented in text or with a text equivalent. For example, alt text for SVG, or aria-label for icons that have meaning or perform actions.
  • Changes in a component’s state are announced by a screen reader. For example, changing aria-expanded="false" to aria-expanded="true" when an accordion is expanded.
  • Color combinations have sufficient contrast.

References #1581 (closed)

Edited by Olena Horal-Koretska

Merge request reports

Loading