ci(danger): allow semantic_commit to run without danger API token
What does this MR do?
The variable gitlab
is not available if danger API token is not
present (for forks) so we use helper
methods to check whether a MR has
squash enabled or not.
Verification
Without token (fork) | With token (this MR) |
---|---|
https://gitlab.com/rettalps/gitlab-ui/-/jobs/2621090064 | https://gitlab.com/gitlab-org/gitlab-ui/-/jobs/2621025928 |
Note that danger-review
never considers fork MRs having squashed commits because it cannot check it. This is a fair assumption because squashing commits is disabled on this project anyway.
Does this MR meet the acceptance criteria?
Conformity
-
Code review guidelines. -
GitLab UI's contributing guidlines. -
If it changes a Pajamas-compliant component's look & feel, the MR has been reviewed by a UX designer. -
If it changes GitLab UI's documentation guidelines, the MR has been reviewed by a Technical Writer. -
If the MR changes a component's API, integration MR(s) have been opened in the following projects to ensure that the @gitlab/ui
package can be upgraded quickly after the changes are released:-
GitLab: mr_url -
CustomersDot: mr_url -
Status Page: mr_url
-
-
Added the ~"component:*"
label(s) if applicable.
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
Security reports checked/validated by a reviewer from the AppSec team
Accessibility
If this MR adds or modifies a component, take a few moments to review the following:
-
All actions and functionality can be done with a keyboard. -
Links, buttons, and controls have a visible focus state. -
All content is presented in text or with a text equivalent. For example, alt text for SVG, or aria-label
for icons that have meaning or perform actions. -
Changes in a component’s state are announced by a screen reader. For example, changing aria-expanded="false"
toaria-expanded="true"
when an accordion is expanded. -
Color combinations have sufficient contrast.
Edited by Peter Leitzen