feat(GlDrawer): add scrim for scrollable content
What does this MR do?
This MR resolves #1777 (closed)
Scrim for scrollable content is added on bottom of scrollable container.
It appears either on bottom of container
or top of footer
if latter presents.
Since every item has bottom padding, when user scrolls to bottom scrims stops being visible.
So it is much easier and more performant to add scrim on permanent basis, rather then render it conditionally based on if scroll bottom was reached.
If footer
presents in drawer
, scrim
is rendered as ::before
pseudo element.
If footer
is not rendered, scrim
is rendered as ::after
pseudo element of scrollable container.
Screenshots before and after?
before |
---|
after |
---|
default_scrim_no_footer |
Does this MR meet the acceptance criteria?
Conformity
-
Code review guidelines. -
GitLab UI's contributing guidlines. -
If it changes a Pajamas-compliant component's look & feel, the MR has been reviewed by a UX designer. -
If it changes GitLab UI's documentation guidelines, the MR has been reviewed by a Technical Writer. -
If the MR changes a component's API, integration MR(s) have been opened in the following projects to ensure that the @gitlab/ui
package can be upgraded quickly after the changes are released:-
GitLab: mr_url -
CustomersDot: mr_url -
Status Page: mr_url
-
-
Added the ~"component:*"
label(s) if applicable.
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
Security reports checked/validated by a reviewer from the AppSec team
Accessibility
If this MR adds or modifies a component, take a few moments to review the following:
-
All actions and functionality can be done with a keyboard. -
Links, buttons, and controls have a visible focus state. -
All content is presented in text or with a text equivalent. For example, alt text for SVG, or aria-label
for icons that have meaning or perform actions. -
Changes in a component’s state are announced by a screen reader. For example, changing aria-expanded="false"
toaria-expanded="true"
when an accordion is expanded. -
Color combinations have sufficient contrast.
Closes #1777 (closed)