Skip to content

Adjust table caption padding

Vishal Tak requested to merge tables-caption-padding into main

What does this MR do?

As per discussions in gitlab!86353 (comment 1025736603) , it was noted that the spacing between the table and its caption is wide. It was not needed/noticed so far because JSON Tables would be the first component to use the table caption.

Currently, the space between the table and the caption is 12px which is almost the space that the design system recommends to separate unrelated elements. We are inheriting that caption spacing from Bootstrap because GitLab UI/Pajamas hasn’t implemented a deliberate decision on this matter.

This MR aims to fix the above.

Does this MR meet the acceptance criteria?

Conformity

  • Code review guidelines.
  • GitLab UI's contributing guidlines.
  • If it changes a Pajamas-compliant component's look & feel, the MR has been reviewed by a UX designer.
  • If it changes GitLab UI's documentation guidelines, the MR has been reviewed by a Technical Writer.
  • If the MR changes a component's API, integration MR(s) have been opened in the following projects to ensure that the @gitlab/ui package can be upgraded quickly after the changes are released:
  • Added the ~"component:*" label(s) if applicable.

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • Security reports checked/validated by a reviewer from the AppSec team

Accessibility

If this MR adds or modifies a component, take a few moments to review the following:

  • All actions and functionality can be done with a keyboard.
  • Links, buttons, and controls have a visible focus state.
  • All content is presented in text or with a text equivalent. For example, alt text for SVG, or aria-label for icons that have meaning or perform actions.
  • Changes in a component’s state are announced by a screen reader. For example, changing aria-expanded="false" to aria-expanded="true" when an accordion is expanded.
  • Color combinations have sufficient contrast.
Edited by Vishal Tak

Merge request reports