Skip to content

Use calc() inside of clamp() to bypass SassC warning

Sascha Eggenberger requested to merge clamp-use-unquote-fix into main

What does this MR do?

MR !2960 (merged) seems to create an issue with the SassC compiler in GitLab upstream, see here

SassC::SyntaxError: Error: Incompatible units: 'vw' and 'rem'.
        on line 19993:29 of stdin
>>   font-size: clamp(1.75rem, -0.1388888889rem + 3.9351851852vw, 2.8125rem);
   ----------------------------^

The problem being that SassC does not fully support modern CSS3 functions like min(), max() & clamp(). Workarounds can be found here & here.

We decided to use calc inside of clamp. Once we upgrade to (dart) sass this workaround can be removed again.

Does this MR meet the acceptance criteria?

Conformity

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • Security reports checked/validated by a reviewer from the AppSec team

Accessibility

If this MR adds or modifies a component, take a few moments to review the following:

  • All actions and functionality can be done with a keyboard.
  • Links, buttons, and controls have a visible focus state.
  • All content is presented in text or with a text equivalent. For example, alt text for SVG, or aria-label for icons that have meaning or perform actions.
  • Changes in a component’s state are announced by a screen reader. For example, changing aria-expanded="false" to aria-expanded="true" when an accordion is expanded.
  • Color combinations have sufficient contrast.
Edited by Peter Hegman

Merge request reports

Loading