Skip to content

chore(vue3): refactor storage of pikaday in datepicker component

Illya Klymov requested to merge xanf-road2vue3-datepicker into main

What does this MR do?

Vue3 reactivity allows tracking any properties, not just declared on data, etc. so referencing this.calendar in our datepicker component will trigger warning.

The simplest way will be using this.$options.calendar instead, however this.$options is read-only in Vue3, so we need to put calendar inside an object, so now this is this.$options.pikaday.calendar

This is forward-compatible change to support @vue/compat #1981 (closed)

Does this MR meet the acceptance criteria?

Conformity

  • Code review guidelines.
  • GitLab UI's contributing guidlines.
  • [N/A] If it changes a Pajamas-compliant component's look & feel, the MR has been reviewed by a UX designer.
  • [N/A] If it changes GitLab UI's documentation guidelines, the MR has been reviewed by a Technical Writer.
  • [N/A] If the MR changes a component's API, integration MR(s) have been opened in the following projects to ensure that the @gitlab/ui package can be upgraded quickly after the changes are released:
  • Added the ~"component:*" label(s) if applicable.

Merge request reports

Loading