Skip to content

fix(datepicker): Render empty string instead of false

Illya Klymov requested to merge xanf-fix-datepicker-default-value into main

What does this MR do?

In !3109 (comment 1150099657) there was discovered that my recent changes in !3109 (merged) changed behavior of component - it started to return 'false' instead of undefined for initial input value

false value is rendered as string 'false' in browsers. However, this is not the case for JSDom. Following snippet prints 'false' in browser and empty string in JSDOM:

const x = document.createElement('input');
x.value = false;
console.log(x.value);

I'm changing code to be consistent and always return string (empty string if empty)

Considering scope of the change and these nuances of JSDOM, I find it ok not to add tests for this change, however I'm open to suggestions if anyone feels this needs to be tested and how you would like to approach testing this one

Does this MR meet the acceptance criteria?

Conformity

  • Code review guidelines.
  • GitLab UI's contributing guidlines.
  • If it changes a Pajamas-compliant component's look & feel, the MR has been reviewed by a UX designer.
  • If it changes GitLab UI's documentation guidelines, the MR has been reviewed by a Technical Writer.
  • If the MR changes a component's API, integration MR(s) have been opened in the following projects to ensure that the @gitlab/ui package can be upgraded quickly after the changes are released:
  • Added the ~"component:*" label(s) if applicable.

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • Security reports checked/validated by a reviewer from the AppSec team

Accessibility

If this MR adds or modifies a component, take a few moments to review the following:

  • All actions and functionality can be done with a keyboard.
  • Links, buttons, and controls have a visible focus state.
  • All content is presented in text or with a text equivalent. For example, alt text for SVG, or aria-label for icons that have meaning or perform actions.
  • Changes in a component’s state are announced by a screen reader. For example, changing aria-expanded="false" to aria-expanded="true" when an accordion is expanded.
  • Color combinations have sufficient contrast.
Edited by Illya Klymov

Merge request reports