Skip to content

fix(dropdowns): fix ResizeObserver loop error

Paul Gascou-Vaillancourt requested to merge fix-resizeobserver-loop into main

What does this MR do?

fix(dropdowns): fix ResizeObserver loop error

This rewrites a previous fix that meant to address an unexpected scrolling issue but ended up causing a ResizeObserver loop error. While the error is harmless, it does cause an error overlay to show up in the GDK, and sends events to our Sentry instance in production. This applies the simpler fix that was outlined in !3484 (merged) which seems to fix both issues.

Re gitlab#415039 (closed)

Repro steps

  1. In the GDK, checkout the master branch and run yarn.
  2. In a short window, try opening the context switcher. It should open properly, but an error overlay should be displayed.
  3. Checkout the integration branch from gitlab!123422 (closed) and run yarn again.
  4. Repeat step 2. Not error overlay should appear.
  5. Navigate to a tall page that has dropdowns toward the bottom, the notification settings for example. Scroll down to one of the last dropdowns and open it. The sroll position within the page should not change.

Screenshots or screen recordings

Before this change, opening the context switcher could cause a ResizeObserver loop error in shorter windows.

Before After
Screenshot_2023-06-12_at_2.16.08_PM No error

Integration merge requests

Does this MR meet the acceptance criteria?

This checklist encourages the authors, reviewers, and maintainers of merge requests (MRs) to confirm changes were analyzed for conformity with the project's guidelines, security and accessibility.

Toggle the acceptance checklist

Conformity

  • Code review guidelines.
  • GitLab UI's contributing guidelines.
  • If it changes a Pajamas-compliant component's look & feel, the MR has been reviewed by a UX designer.
  • If it changes GitLab UI's documentation guidelines, the MR has been reviewed by a Technical Writer.
  • If the MR changes a component's API, integration MR(s) have been opened (see integration merge requests above).
  • Added the ~"component:*" label(s) if applicable.

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • Security reports checked/validated by a reviewer from the AppSec team

Accessibility

If this MR adds or modifies a component, take a few moments to review the following:

  • All actions and functionality can be done with a keyboard.
  • Links, buttons, and controls have a visible focus state.
  • All content is presented in text or with a text equivalent. For example, alt text for SVG, or aria-label for icons that have meaning or perform actions.
  • Changes in a component’s state are announced by a screen reader. For example, changing aria-expanded="false" to aria-expanded="true" when an accordion is expanded.
  • Color combinations have sufficient contrast.
Edited by Paul Gascou-Vaillancourt

Merge request reports

Loading