Skip to content

feat(DisclosureDropdown): borderPosition property

What does this MR do?

Adds a borderPosition property to the GlDisclosureDropdownGroup component that allows customizing the position of the group separator.

Motivation

I’m working on a feature that conditionally displays a group with custom content in the "Edit" dropdown:

Screenshot 2023-06-12 at 3.20.39 PM.png

I need to display a separator below the "Workspaces" group. When the user doesn’t have a Premium+ plan, the Workspaces group and its separator are not displayed. The bordered provided by GlDisclosureDropdownGroup displays a separator above the group, and it’s not customizable. This Merge Request adds this customization.

Screenshots or screen recordings

2023-06-12_15.00.44

Integration merge requests

Does this MR meet the acceptance criteria?

This checklist encourages the authors, reviewers, and maintainers of merge requests (MRs) to confirm changes were analyzed for conformity with the project's guidelines, security and accessibility.

Toggle the acceptance checklist

Conformity

  • Code review guidelines.
  • GitLab UI's contributing guidelines.
  • If it changes a Pajamas-compliant component's look & feel, the MR has been reviewed by a UX designer.
  • If it changes GitLab UI's documentation guidelines, the MR has been reviewed by a Technical Writer.
  • If the MR changes a component's API, integration MR(s) have been opened (see integration merge requests above).
  • Added the ~"component:*" label(s) if applicable.

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • Security reports checked/validated by a reviewer from the AppSec team

Accessibility

If this MR adds or modifies a component, take a few moments to review the following:

  • All actions and functionality can be done with a keyboard.
  • Links, buttons, and controls have a visible focus state.
  • All content is presented in text or with a text equivalent. For example, alt text for SVG, or aria-label for icons that have meaning or perform actions.
  • Changes in a component’s state are announced by a screen reader. For example, changing aria-expanded="false" to aria-expanded="true" when an accordion is expanded.
  • Color combinations have sufficient contrast.
Edited by Enrique Alcántara

Merge request reports

Loading