Skip to content

fix(dropdowns): loosen up auto-placement settings

Paul Gascou-Vaillancourt requested to merge add-dropdowns-auto-placements into main

What does this MR do?

fix(dropdowns): loosen up auto-placement settings

Allows corner-positioned dropdowns to be auto-positioned in any corner if the prefered one lacks space for the dropdown to render properly. Previously, dropdowns could only be auto-positioned on the vertical axis, meaning that they would remain on the same side of their toggle. In rare cases, this poses issues for dropdowns that might also lack horizontal spacing and therefore need to be allowed to flip sides as well.

This is a reaction to a failure that currently blocks the @gitlab/ui upgrade MR at gitlab!124352 (merged). The failure is caused by !3530 (merged). The integration MR did not catch this: gitlab!124113 (closed).

How to reproduce the bug

  1. Checkout the GitLab branch from gitlab!124352 (merged).
  2. Run yarn.
  3. In some epics board, click on the more icon next to an epic.
    • The dropdown is partially visible as it is left-aligned even though this causes it to overflow its container.
  4. Checkout the branch from gitlab!124797 (closed).
  5. Repeat steps 2-3.
    • The dropdown should now properly reposition itself to the left so that it's fully visible.

Screenshots or screen recordings

Before After
Screenshot_2023-06-27_at_3.42.21_PM Screenshot_2023-06-27_at_3.41.50_PM

Integration merge requests

Does this MR meet the acceptance criteria?

This checklist encourages the authors, reviewers, and maintainers of merge requests (MRs) to confirm changes were analyzed for conformity with the project's guidelines, security and accessibility.

Toggle the acceptance checklist

Conformity

  • Code review guidelines.
  • GitLab UI's contributing guidelines.
  • If it changes a Pajamas-compliant component's look & feel, the MR has been reviewed by a UX designer.
  • If it changes GitLab UI's documentation guidelines, the MR has been reviewed by a Technical Writer.
  • If the MR changes a component's API, integration MR(s) have been opened (see integration merge requests above).
  • Added the ~"component:*" label(s) if applicable.

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • Security reports checked/validated by a reviewer from the AppSec team

Accessibility

If this MR adds or modifies a component, take a few moments to review the following:

  • All actions and functionality can be done with a keyboard.
  • Links, buttons, and controls have a visible focus state.
  • All content is presented in text or with a text equivalent. For example, alt text for SVG, or aria-label for icons that have meaning or perform actions.
  • Changes in a component’s state are announced by a screen reader. For example, changing aria-expanded="false" to aria-expanded="true" when an accordion is expanded.
  • Color combinations have sufficient contrast.
Edited by Paul Gascou-Vaillancourt

Merge request reports

Loading