Skip to content

fix(GlEmptyState): update styling to be Pajamas compliant

Peter Hegman requested to merge align-empty-state-with-pajamas into main

What does this MR do?

Follow-up from gitlab!125626 (comment 1467329107)

It came up in a review the the spacing and SVG size of GLEmptyState was not Pajamas compliant. This MR updates the spacing and SVG size to be Pajamas compliant. The spacing issues were due to CSS classes in gitlab-org/gitlab so they weren't visible in Storybook. As for the SVG size change we default the height of SVGs to 144 because that is the size they were designed for.

Screenshots or screen recordings

Before After
Screenshot 2023-07-21 at 12.38.36 PM.png Screenshot 2023-07-21 at 12.38.02 PM.png

How to test

I was having troubles getting yarn link working (running into JS errors) so I just copied the built component from gitlab-org/gitlab-ui to gitlab-org/gitlab .

  1. In gitlab-org/gitlab-ui run yarn build . Copy dist/components/regions/empty_state/empty_state.js
  2. In gitlab-org/gitlab delete node_modules/@gitlab/ui/dist/components/regions/empty_state/empty_state.js . Paste the file copied in the above step.
  3. Run gdk restart
  4. Navigate to /admin/deploy_keys

Integration merge requests

Not adding/removing props so there shouldn't be any failing specs due to that. It is possible there will be failing specs due to snapshots being slightly different from adding/removing CSS classes but those are easy to fix.

Does this MR meet the acceptance criteria?

This checklist encourages the authors, reviewers, and maintainers of merge requests (MRs) to confirm changes were analyzed for conformity with the project's guidelines, security and accessibility.

Toggle the acceptance checklist

Conformity

  • Code review guidelines.
  • GitLab UI's contributing guidelines.
  • If it changes a Pajamas-compliant component's look & feel, the MR has been reviewed by a UX designer.
  • [-] If it changes GitLab UI's documentation guidelines, the MR has been reviewed by a Technical Writer.
  • If the MR changes a component's API, integration MR(s) have been opened (see integration merge requests above).
  • Added the ~"component:*" label(s) if applicable.

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] Security reports checked/validated by a reviewer from the AppSec team

Accessibility

If this MR adds or modifies a component, take a few moments to review the following:

  • All actions and functionality can be done with a keyboard.
  • Links, buttons, and controls have a visible focus state.
  • All content is presented in text or with a text equivalent. For example, alt text for SVG, or aria-label for icons that have meaning or perform actions.
  • Changes in a component’s state are announced by a screen reader. For example, changing aria-expanded="false" to aria-expanded="true" when an accordion is expanded.
  • Color combinations have sufficient contrast.
Edited by Peter Hegman

Merge request reports