Skip to content

fix(GlChart): make chart legend and axis text visible in dark mode

Elwyn Benson requested to merge 2235-dark-mode-chart-legend into main

What does this MR do?

Updates the chart legend and axis text colour to use CSS variables, which provide better contrast in dark mode.

The chart legend text colour is set to --gl-text-color and chart axis text colour is set to --gray-300 in dark mode.

This change is in the base GlChart so propagates through to all other charts which use that component.

--gl-text-color has been set inside the Storybook preview frame (storybook_dark_mode.scss) so that text colour in Storybook is the same as GitLab (gray-50 instead of #fff), as well as using the expected CSS variable name so components can rely on it being there.

This MR does not tackle the dark palette changes noted in the issue, only the legend visibility.

Screenshots or screen recordings

Before After
image image

Note2: The series labels do not show up, but when running in GitLab with the inverted dark-mode colours they do show up:

Storybook chart GitLab chart
image image

I have not made any changes to these.

Does this MR meet the acceptance criteria?

This checklist encourages the authors, reviewers, and maintainers of merge requests (MRs) to confirm changes were analyzed for conformity with the project's guidelines, security and accessibility.

Toggle the acceptance checklist

Conformity

  • Code review guidelines.
  • GitLab UI's contributing guidelines.
  • If it changes a Pajamas-compliant component's look & feel, the MR has been reviewed by a UX designer.
  • [-] If it changes GitLab UI's documentation guidelines, the MR has been reviewed by a Technical Writer.
  • [-] If the MR changes a component's API, integration MR(s) have been opened (see integration merge requests above).
  • Added the ~"component:*" label(s) if applicable.

Accessibility

If this MR adds or modifies a component, take a few moments to review the following:

  • [-] All actions and functionality can be done with a keyboard.
  • [-] Links, buttons, and controls have a visible focus state.
  • [-] All content is presented in text or with a text equivalent. For example, alt text for SVG, or aria-label for icons that have meaning or perform actions.
  • [-] Changes in a component’s state are announced by a screen reader. For example, changing aria-expanded="false" to aria-expanded="true" when an accordion is expanded.
  • Color combinations have sufficient contrast.
Edited by Elwyn Benson

Merge request reports