Skip to content

feat(GlLink): Removes text size override in gl-link

Miguel Rincon requested to merge 2347-gl-link-sets-a-different-font-size-from-wrapping-text into main

What does this MR do?

Fixes #2347 (closed), I used a feat(GlLink): to indicate this change requires some testing.

Removes text size override in <gl-link> so the link font size behaves like an <a> element.

Screenshots or screen recordings

I've opened an integration MR for gitlab at gitlab!134738 (closed).

url before after
http://gdk.test:3000/root image image
http://gdk.test:3000 image image
http://gdk.test:3000/flightjs image image
http://gdk.test:3000/flightjs/Flight image image
http://gdk.test:3000/flightjs/Flight/-/issues image image
http://gdk.test:3000/flightjs/Flight/-/issues/10 image image
http://gdk.test:3000/admin/application_settings/general image image
http://gdk.test:3000/admin/abuse_reports?status=open image image
http://gdk.test:3000/admin/abuse_reports/24 image image
http://gdk.test:3000/admin/runners image image
I noticed there was a small shift in the avatar of the runners page, so I tried 2 other pages directly in .com. manually disabling the rule to see if there is a shift:

!3754 (merged)

2023-10-24_12.53.55

#2347 (closed)

2023-10-24_12.57.16

Integration merge requests

Does this MR meet the acceptance criteria?

This checklist encourages the authors, reviewers, and maintainers of merge requests (MRs) to confirm changes were analyzed for conformity with the project's guidelines, security and accessibility.

Toggle the acceptance checklist

Conformity

  • Code review guidelines.
  • GitLab UI's contributing guidelines.
  • If it changes a Pajamas-compliant component's look & feel, the MR has been reviewed by a UX designer.
  • If it changes GitLab UI's documentation guidelines, the MR has been reviewed by a Technical Writer.
  • If the MR changes a component's API, integration MR(s) have been opened (see integration merge requests above).
  • Added the ~"component:*" label(s) if applicable.

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • Security reports checked/validated by a reviewer from the AppSec team

Accessibility

If this MR adds or modifies a component, take a few moments to review the following:

  • All actions and functionality can be done with a keyboard.
  • Links, buttons, and controls have a visible focus state.
  • All content is presented in text or with a text equivalent. For example, alt text for SVG, or aria-label for icons that have meaning or perform actions.
  • Changes in a component’s state are announced by a screen reader. For example, changing aria-expanded="false" to aria-expanded="true" when an accordion is expanded.
  • Color combinations have sufficient contrast.

Closes #2347 (closed)

Edited by Miguel Rincon

Merge request reports