Skip to content

Fix spacing in GlAvatarInline

Chad Lavimoniere requested to merge 865-glavatarinline-calculating-size-doesn-t-factor-in-the-badge-when-collapsed into main

What does this MR do?

Absolute positioning was used previously for this, which necessitated a lot of manual size management. This resulted in a bug where the parent component did not have the right width.

This change uses negative right margin on avatars when the avatar-inline component is collapsed so that the parent element will always have the same size as the apparent size of the avatars.

This change also corrects the way positive right margins are applied when the avatars-inline is not collapsed so that the final avatar does not have unnecessary right margin.

Screenshots or screen recordings

Before and after

Before After
Screenshot_2023-12-07_at_11.54.34 image
Screenshot_2023-12-07_at_11.55.20 Screenshot_2023-12-07_at_11.55.33

Screen recording

In this screen recording, I show that the avatars-inline component is working as expected at both avatar sizes, collapsed and uncollapsed, and with different numbers of max visible avatars. I've added a 2px dotted red outline to the parent element of the avatars-inline component so that its bounding box is clear:

Screen_Recording_2023-12-07_at_11.43.27

Integration merge requests

Does this MR meet the acceptance criteria?

This checklist encourages the authors, reviewers, and maintainers of merge requests (MRs) to confirm changes were analyzed for conformity with the project's guidelines, security and accessibility.

Toggle the acceptance checklist

Conformity

  • Code review guidelines.
  • GitLab UI's contributing guidelines.
  • If it changes a Pajamas-compliant component's look & feel, the MR has been reviewed by a UX designer.
  • If it changes GitLab UI's documentation guidelines, the MR has been reviewed by a Technical Writer.
  • If the MR changes a component's API, integration MR(s) have been opened (see integration merge requests above).
  • Added the ~"component:*" label(s) if applicable.

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • Security reports checked/validated by a reviewer from the AppSec team

Accessibility

If this MR adds or modifies a component, take a few moments to review the following:

  • All actions and functionality can be done with a keyboard.
  • Links, buttons, and controls have a visible focus state.
  • All content is presented in text or with a text equivalent. For example, alt text for SVG, or aria-label for icons that have meaning or perform actions.
  • Changes in a component’s state are announced by a screen reader. For example, changing aria-expanded="false" to aria-expanded="true" when an accordion is expanded.
  • Color combinations have sufficient contrast.

Closes #865 (closed)

Edited by Chad Lavimoniere

Merge request reports