Skip to content

feat(GlDuoChat): slash commands for chat as a prop

Denys Mishunov requested to merge 430213-slash-commands-as-a-prop into main

What does this MR do?

This MR is the first step to allow external consumers of the GlDuoChat component to define the custom slash commands.

Integration Strategy:

This component is used in two projects in production: the GitLab project and the VSCode extension. Here's how this MR affects both.

The GitLab project

Since we do not provide any slash commands in GitLab and the new slashCommands defaults to an empty array in this MR, there's no change to the GlDuoChat component's integration into GitLab project - it will continue working without slash commands as it does today.

The VSCode extension

The updated integration into the extension is introduced in feat(chat): set up Duo Chat WebView with initia... (gitlab-vscode-extension!1354 - merged). The matter of syncing the gitlab-ui change from this MR and the MR against the extension is simple as well: the extension project does not have automated mechanism to upgrade gitlab-ui package - it is a manual process. So the planned orchestration for the extension project is as follows:

This way both the gitlab-ui upgrade and the integration will be merged into the extension project at the same time.

Screenshots or screen recordings

Integration merge requests

Does this MR meet the acceptance criteria?

This checklist encourages the authors, reviewers, and maintainers of merge requests (MRs) to confirm changes were analyzed for conformity with the project's guidelines, security and accessibility.

Toggle the acceptance checklist

Conformity

  • Code review guidelines.
  • GitLab UI's contributing guidelines.
  • If it changes a Pajamas-compliant component's look & feel, the MR has been reviewed by a UX designer.
  • If it changes GitLab UI's documentation guidelines, the MR has been reviewed by a Technical Writer.
  • If the MR changes a component's API, integration MR(s) have been opened (see integration merge requests above).
  • Added the ~"component:*" label(s) if applicable.

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • Security reports checked/validated by a reviewer from the AppSec team

Accessibility

If this MR adds or modifies a component, take a few moments to review the following:

  • All actions and functionality can be done with a keyboard.
  • Links, buttons, and controls have a visible focus state.
  • All content is presented in text or with a text equivalent. For example, alt text for SVG, or aria-label for icons that have meaning or perform actions.
  • Changes in a component’s state are announced by a screen reader. For example, changing aria-expanded="false" to aria-expanded="true" when an accordion is expanded.
  • Color combinations have sufficient contrast.

References https://gitlab.com/gitlab-org/gitlab/-/issues/430213

Edited by Denys Mishunov

Merge request reports