Remove some utility mixins
What does this MR do?
This removes a few utility mixins so that Tailwind can take precedence.
-
appearance.scss
- The
gl-appearance-none
has been removed. - Internal usages of its have been migrated to Tailwind's
@apply
directive. - Consumers will need to enable the
appearance
Tailwind core plugin. - No renames necessary.
- The
-
content.scss
- This only defined the
gl-content-empty
utility mixin which is only used internally. - Renamed
gl-content-empty
tocontent-empty
and moved it to the internal mixins file. - Deleted
content.scss
so that we don't generate utility classes for it anymore. - Consumers can enable the
content
Tailwind core plugin.
- This only defined the
-
masks.scss
- This only defined the
gl-mask-chevron-down
utility mixin which is only used internally. - Renamed
mask-chevron-down
tocontent-empty
and moved it to the internal mixins file. - Deleted
masks.scss
so that we don't generate utility classes for it anymore.
- This only defined the
-
mix-blend-mode.scss
- This only defined the
gl-mix-blend-mode-luminosity
utility which we don't use anywhere. - Deleted
mix-blend-mode.scss
. - Consumers can enable the
mixBlendMode
Tailwind core plugin.
- This only defined the
-
table.scss
- This only defined the
gl-table-layout-fixed
utility which we use in GitLab. - Deleted
table.scss
. - Consumers should enable the
tableLayout
Tailwind core plugin. - Rename
gl-table-layout-fixed
togl-table-fixed
.
- This only defined the
-
user-select.scss
- Defined
gl-user-select-none
andgl-user-select-text
utilities. - Internal usages have been migrated to Tailwind's
@apply
directive. - Deleted
user-select.scss
. - Consumers should enable the
userSelect
Tailwind core plugin. - Rename
gl-user-select-none
togl-select-none
. - Rename
gl-user-select-text
togl-select-text
.
- Defined
Re #2391 (closed), #2398 (closed), #2405 (closed), #2410 (closed), #2414 (closed)
Screenshots or screen recordings
Integration merge requests
-
GitLab: gitlab!145433 (closed) - [-] CustomersDot: mr_url
- [-] Status Page: mr_url
Does this MR meet the acceptance criteria?
This checklist encourages the authors, reviewers, and maintainers of merge requests (MRs) to confirm changes were analyzed for conformity with the project's guidelines, security and accessibility.
Toggle the acceptance checklist
Conformity
-
Code review guidelines. -
GitLab UI's contributing guidelines. -
If it changes a Pajamas-compliant component's look & feel, the MR has been reviewed by a UX designer. -
If it changes GitLab UI's documentation guidelines, the MR has been reviewed by a Technical Writer. -
If the MR changes a component's API, integration MR(s) have been opened (see integration merge requests above). -
Added the ~"component:*"
label(s) if applicable.
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
Security reports checked/validated by a reviewer from the AppSec team
Accessibility
If this MR adds or modifies a component, take a few moments to review the following:
-
All actions and functionality can be done with a keyboard. -
Links, buttons, and controls have a visible focus state. -
All content is presented in text or with a text equivalent. For example, alt text for SVG, or aria-label
for icons that have meaning or perform actions. -
Changes in a component’s state are announced by a screen reader. For example, changing aria-expanded="false"
toaria-expanded="true"
when an accordion is expanded. -
Color combinations have sufficient contrast.
Edited by Paul Gascou-Vaillancourt