Skip to content

GlLabel: Fix focus ring

Sascha Eggenberger requested to merge gl-label-fix-focus-ring into main

What does this MR do?

GlLabel: Fix focus ring

There are some instances where the CSS variable --label-background-color seems to be unset. This causes a problem as we don't have a fallback value set, so the focus ring will just not appear at all.

This MR adds $white as a fallback value to --label-background-color

Screenshots or screen recordings

Before After
before after
before2 after2

This can only be reproduced in the product itself. I was able to reproduce it in many places, but the easiest might be in an issuable in an comment or in the activity feed.

Integration merge requests

Does this MR meet the acceptance criteria?

This checklist encourages the authors, reviewers, and maintainers of merge requests (MRs) to confirm changes were analyzed for conformity with the project's guidelines, security and accessibility.

Toggle the acceptance checklist

Conformity

  • Code review guidelines.
  • GitLab UI's contributing guidelines.
  • If it changes a Pajamas-compliant component's look & feel, the MR has been reviewed by a UX designer.
  • If it changes GitLab UI's documentation guidelines, the MR has been reviewed by a Technical Writer.
  • If the MR changes a component's API, integration MR(s) have been opened (see integration merge requests above).
  • Added the ~"component:*" label(s) if applicable.

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • Security reports checked/validated by a reviewer from the AppSec team

Accessibility

If this MR adds or modifies a component, take a few moments to review the following:

  • All actions and functionality can be done with a keyboard.
  • Links, buttons, and controls have a visible focus state.
  • All content is presented in text or with a text equivalent. For example, alt text for SVG, or aria-label for icons that have meaning or perform actions.
  • Changes in a component’s state are announced by a screen reader. For example, changing aria-expanded="false" to aria-expanded="true" when an accordion is expanded.
  • Color combinations have sufficient contrast.

Related to gitlab#425467 (closed)

Merge request reports