Skip to content

feat(GlFormTextarea): add support for character count

Peter Hegman requested to merge 1243-add-character-count-support-to-glformtextarea into main

What does this MR do?

Closes #1243 (closed)

A while back we implemented character count for GlFormTextarea but it needed to be reverted because it caused regressions due to the root element being changed from a textarea to a div. This MR re-implements this feature and fixes this issue by only wrapping the textarea when characterCount prop is set. This means all existing instances should not have issues because the characterCount prop will not be set.

We have a few instances of character count in gitlab-org/gitlab that will be able to be replaced by this feature.

Screenshots or screen recordings

Screen_Recording_2024-04-16_at_11.01.55_AM

Integration merge requests

Does this MR meet the acceptance criteria?

This checklist encourages the authors, reviewers, and maintainers of merge requests (MRs) to confirm changes were analyzed for conformity with the project's guidelines, security and accessibility.

Toggle the acceptance checklist

Conformity

  • Code review guidelines.
  • GitLab UI's contributing guidelines.
  • If it changes a Pajamas-compliant component's look & feel, the MR has been reviewed by a UX designer.
  • If it changes GitLab UI's documentation guidelines, the MR has been reviewed by a Technical Writer.
  • If the MR changes a component's API, integration MR(s) have been opened (see integration merge requests above).
  • Added the ~"component:*" label(s) if applicable.

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] Security reports checked/validated by a reviewer from the AppSec team

Accessibility

If this MR adds or modifies a component, take a few moments to review the following:

  • All actions and functionality can be done with a keyboard.
  • Links, buttons, and controls have a visible focus state.
  • All content is presented in text or with a text equivalent. For example, alt text for SVG, or aria-label for icons that have meaning or perform actions.
  • Changes in a component’s state are announced by a screen reader. For example, changing aria-expanded="false" to aria-expanded="true" when an accordion is expanded.
  • Color combinations have sufficient contrast.
Edited by Peter Hegman

Merge request reports