Skip to content

feat(CSS): remove `gl-gap-x/y-*` CSS utility classes

Peter Hegman requested to merge remove-gap-x/y-utilities into main

What does this MR do?

The CSS utils task group is in the process of migrating legacy CSS utilities to the Tailwind equivalent. There was a conflict between the gl-gap-x/y-* CSS utility classes and the Tailwind gap utility classes that was causing duplicate spacing. This issue was fixed in gitlab!150608 (merged). This MR removes the old gl-gap-x/y-* CSS utility classes that use margin for spacing. Going forward gl-gap-* will always use the gap CSS property. If you want spacing that uses margin you would use gl-space-*. In gitlab#456632 (closed) and gitlab#456631 (closed) we will migrate gl-column-gap-* and gl-row-gap utilities to the Tailwind equivalent (gl-gap-x/y-*).

Integration merge requests

Does this MR meet the acceptance criteria?

This checklist encourages the authors, reviewers, and maintainers of merge requests (MRs) to confirm changes were analyzed for conformity with the project's guidelines, security and accessibility.

Toggle the acceptance checklist

Conformity

  • Code review guidelines.
  • GitLab UI's contributing guidelines.
  • If it changes a Pajamas-compliant component's look & feel, the MR has been reviewed by a UX designer.
  • If it changes GitLab UI's documentation guidelines, the MR has been reviewed by a Technical Writer.
  • If the MR changes a component's API, integration MR(s) have been opened (see integration merge requests above).
  • Added the ~"component:*" label(s) if applicable.

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • Security reports checked/validated by a reviewer from the AppSec team

Accessibility

If this MR adds or modifies a component, take a few moments to review the following:

  • All actions and functionality can be done with a keyboard.
  • Links, buttons, and controls have a visible focus state.
  • All content is presented in text or with a text equivalent. For example, alt text for SVG, or aria-label for icons that have meaning or perform actions.
  • Changes in a component’s state are announced by a screen reader. For example, changing aria-expanded="false" to aria-expanded="true" when an accordion is expanded.
  • Color combinations have sufficient contrast.
Edited by Peter Hegman

Merge request reports