Skip to content

chore(duochat): fixes chat submition for IME

Eduardo Bonet requested to merge duochat/fix-japanese-ime into main

What does this MR do?

chore(duochat): fixes chat submition for IME

Some languages (eg Japanese IME) allow users to select an entry based on the typed letters, which is selected by pressed enter. Duo chat automatically sends the message without taking this into account, causing users to send unfinished messages. Taking isComposing into account prevents this from happening.

See issue #2537 (closed)

Screenshots or screen recordings

Before:

2024-06-06_10.55.57

After

2024-06-06_10.52.06

Steps to reproduce

  1. Enable Japanese IME keyboard
  2. On the DuoChat, type something, press up to open the choices, and select a choice with 'enter'
  3. Before, selecting an option would already send the message. Now it first accepts the change, and then another 'enter' to send the message. Behaviour for english keyboard remains the same.

Integration merge requests

Does this MR meet the acceptance criteria?

This checklist encourages the authors, reviewers, and maintainers of merge requests (MRs) to confirm changes were analyzed for conformity with the project's guidelines, security and accessibility.

Toggle the acceptance checklist

Conformity

  • Code review guidelines.
  • GitLab UI's contributing guidelines.
  • If it changes a Pajamas-compliant component's look & feel, the MR has been reviewed by a UX designer.
  • If it changes GitLab UI's documentation guidelines, the MR has been reviewed by a Technical Writer.
  • If the MR changes a component's API, integration MR(s) have been opened (see integration merge requests above).
  • Added the ~"component:*" label(s) if applicable.

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • Security reports checked/validated by a reviewer from the AppSec team

Accessibility

If this MR adds or modifies a component, take a few moments to review the following:

  • All actions and functionality can be done with a keyboard.
  • Links, buttons, and controls have a visible focus state.
  • All content is presented in text or with a text equivalent. For example, alt text for SVG, or aria-label for icons that have meaning or perform actions.
  • Changes in a component’s state are announced by a screen reader. For example, changing aria-expanded="false" to aria-expanded="true" when an accordion is expanded.
  • Color combinations have sufficient contrast.
Edited by Eduardo Bonet

Merge request reports