Skip to content

Draft: fix:remove bootstrap/scss/code stylesheet from imported bootstrap styles

Julie Huang requested to merge jh/fix-code-preview-styles-in-storybook into main

What does this MR do?

This MR removes bootstrap/scss/code stylesheet import from bootstrap.scss, which styles the storybook preview.

This stylesheet causes naked strings in storybook code blocks to appear black. This makes them invisible against the dark background the code block is rendered on.

Screenshots or screen recordings

Before After
Screenshot_2024-08-05_at_4.30.39_PM Screenshot_2024-08-05_at_4.30.59_PM
Screenshot_2024-08-05_at_4.30.15_PM Screenshot_2024-08-05_at_4.29.46_PM

How to validate changes locally

  1. Run yarn storybook in gitlab-ui root
  2. Navigate to http://localhost:9001/?path=/docs/base-banner--docs in browser to open up the banner component docs in your local storybook
  3. Click on "Show Code" on any of the component stories

Integration merge requests

Does this MR meet the acceptance criteria?

This checklist encourages the authors, reviewers, and maintainers of merge requests (MRs) to confirm changes were analyzed for conformity with the project's guidelines, security and accessibility.

Toggle the acceptance checklist

Conformity

  • Code review guidelines.
  • GitLab UI's contributing guidelines.
  • If it changes a Pajamas-compliant component's look & feel, the MR has been reviewed by a UX designer.
  • If it changes GitLab UI's documentation guidelines, the MR has been reviewed by a Technical Writer.
  • If the MR changes a component's API, integration MR(s) have been opened (see integration merge requests above).
  • Added the ~"component:*" label(s) if applicable.

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • Security reports checked/validated by a reviewer from the AppSec team

Accessibility

If this MR adds or modifies a component, take a few moments to review the following:

  • All actions and functionality can be done with a keyboard.
  • Links, buttons, and controls have a visible focus state.
  • All content is presented in text or with a text equivalent. For example, alt text for SVG, or aria-label for icons that have meaning or perform actions.
  • Changes in a component’s state are announced by a screen reader. For example, changing aria-expanded="false" to aria-expanded="true" when an accordion is expanded.
  • Color combinations have sufficient contrast.
Edited by Julie Huang

Merge request reports

Loading