Skip to content

feat(Avatar): Use new darkmode colors

Sascha Eggenberger requested to merge avatar-new-darkmode-color-updates into main

What does this MR do?

feat(Avatar): Use new darkmode colors

Use alpha transparency for new darkmode. Also updats the values for light mode to follow suit.

  • Changes backgrounds to use alpha transparency of 0.24 with base values of 200
  • Changes text to use 200 for darkmode and 800 color for lightmode

All color combinations were tested and are surpassing a WCAG AA+ rating.

This is a follow-up to !4475 (merged), see !4475 (comment 2034779644)

Screenshots or screen recordings

Before After
before_dark after_dark
before after

Component url

http://localhost:9001/?path=/story/base-avatar--all-identicons

Does this MR meet the acceptance criteria?

This checklist encourages the authors, reviewers, and maintainers of merge requests (MRs) to confirm changes were analyzed for conformity with the project's guidelines, security and accessibility.

Toggle the acceptance checklist

Conformity

  • Code review guidelines.
  • GitLab UI's contributing guidelines.
  • If it changes a Pajamas-compliant component's look & feel, the MR has been reviewed by a UX designer.
  • If it changes GitLab UI's documentation guidelines, the MR has been reviewed by a Technical Writer.
  • If the MR changes a component's API, integration MR(s) have been opened (see integration merge requests above).
  • Added the ~"component:*" label(s) if applicable.

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • Security reports checked/validated by a reviewer from the AppSec team

Accessibility

If this MR adds or modifies a component, take a few moments to review the following:

  • All actions and functionality can be done with a keyboard.
  • Links, buttons, and controls have a visible focus state.
  • All content is presented in text or with a text equivalent. For example, alt text for SVG, or aria-label for icons that have meaning or perform actions.
  • Changes in a component’s state are announced by a screen reader. For example, changing aria-expanded="false" to aria-expanded="true" when an accordion is expanded.
  • Color combinations have sufficient contrast.

Related to gitlab#452231 (closed), gitlab-org/gitlab-services/design.gitlab.com#1719 (closed)

Edited by Sascha Eggenberger

Merge request reports

Loading