Draft: refactor(Feedback): Feedback dark tokens
What does this MR do?
- Refactor tooltip and popover dark mode design tokens.
- Refactor toast to use design tokens.
- Increased visual consistency for similar popup feedback elements based on dark mode design direction.
Screenshots or screen recordings
Before | After | Notes |
---|---|---|
Instead of inversion, the tooltip uses a lighter background than any surface to bring it forward. This is beneficial for those who use dark mode for vision impairments where light backgrounds make to hard to read and decipher content. It also helps the tooltip to feel more integrated and related to the referring element. | ||
Use the same background as the tooltip to ensure it comes more forward than other surfaces, but still feels integrated and not harsh. The link color has to be lightened a step above text.color.link for sufficient contrast against the background. Although not related to the design token work, the link would still fail WCAG Success Criteria 1.4.1 Use of Color so an underline has been added for all modes in addition to the color change so that it's differentiated from surrounding content. |
||
Use the same background as the others. Because of the darker surface this doesn't require the inverse effect in dark mode like it does in light mode to stand out. Note that the action doesn't have an underline like a link of the same color does in the popover, this is because the action isn't inline with other text and on its own has sufficient contrast with the background. |
Integration merge requests
-
GitLab: mr_url -
CustomersDot: mr_url -
Status Page: mr_url
Does this MR meet the acceptance criteria?
This checklist encourages the authors, reviewers, and maintainers of merge requests (MRs) to confirm changes were analyzed for conformity with the project's guidelines, security and accessibility.
Toggle the acceptance checklist
Conformity
-
Code review guidelines. -
GitLab UI's contributing guidelines. -
If it changes a Pajamas-compliant component's look & feel, the MR has been reviewed by a UX designer. -
If it changes GitLab UI's documentation guidelines, the MR has been reviewed by a Technical Writer. -
If the MR changes a component's API, integration MR(s) have been opened (see integration merge requests above). -
Added the ~"component:*"
label(s) if applicable.
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
Security reports checked/validated by a reviewer from the AppSec team
Accessibility
If this MR adds or modifies a component, take a few moments to review the following:
-
All actions and functionality can be done with a keyboard. -
Links, buttons, and controls have a visible focus state. -
All content is presented in text or with a text equivalent. For example, alt text for SVG, or aria-label
for icons that have meaning or perform actions. -
Changes in a component’s state are announced by a screen reader. For example, changing aria-expanded="false"
toaria-expanded="true"
when an accordion is expanded. -
Color combinations have sufficient contrast.
Related to gitlab-org/gitlab-services/design.gitlab.com#1886, #2733 (closed)
Edited by Jeremy Elder