Skip to content

feat(Toggle): Change to 20px size

Sascha Eggenberger requested to merge toggle-change-to-20px-size into main

What does this MR do?

Changes the size of the toggle to a 20px size similar to the recent changes to Labels and Badges.

This MR replaces the efforts made in feat(Toggle): Add small variant (!3401 - closed) in favor of having a single size (one size fits all approach).

The first part was to adjust the icons used in feat(Toggle): Change icon size to xs (!4505 - merged).

Before After
inline_before inline_after1
before after1

Test

http://localhost:9001/?path=/story/base-toggle--default

Does this MR meet the acceptance criteria?

This checklist encourages the authors, reviewers, and maintainers of merge requests (MRs) to confirm changes were analyzed for conformity with the project's guidelines, security and accessibility.

Toggle the acceptance checklist

Conformity

  • Code review guidelines.
  • GitLab UI's contributing guidelines.
  • If it changes a Pajamas-compliant component's look & feel, the MR has been reviewed by a UX designer.
  • If it changes GitLab UI's documentation guidelines, the MR has been reviewed by a Technical Writer.
  • If the MR changes a component's API, integration MR(s) have been opened (see integration merge requests above).
  • Added the ~"component:*" label(s) if applicable.

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • Security reports checked/validated by a reviewer from the AppSec team

Accessibility

If this MR adds or modifies a component, take a few moments to review the following:

  • All actions and functionality can be done with a keyboard.
  • Links, buttons, and controls have a visible focus state.
  • All content is presented in text or with a text equivalent. For example, alt text for SVG, or aria-label for icons that have meaning or perform actions.
  • Changes in a component’s state are announced by a screen reader. For example, changing aria-expanded="false" to aria-expanded="true" when an accordion is expanded.
  • Color combinations have sufficient contrast.

Related to gitlab#469616 (closed)

Edited by Sascha Eggenberger

Merge request reports