Skip to content

feat(Forms): Update design tokens

Jeremy Elder requested to merge jeldergl-control-dark-tokens-2 into main

What does this MR do?

  • Visually distinguish :disabled from :read-only inputs.
  • Use subtle for descriptions so the text doesn't compete as much visually with labels

Changes based on original exploration and discussions in !4472 (closed).

Screenshots or screen recordings

Screenshots taken from https://gitlab-org.gitlab.io/gitlab-ui/?path=/story/base-form-form--default which includes instances of all elements receiving updates.

Before After
Form light before Form light after
Form dark before Form dark after

Integration merge requests

Does this MR meet the acceptance criteria?

This checklist encourages the authors, reviewers, and maintainers of merge requests (MRs) to confirm changes were analyzed for conformity with the project's guidelines, security and accessibility.

Toggle the acceptance checklist

Conformity

  • Code review guidelines.
  • GitLab UI's contributing guidelines.
  • If it changes a Pajamas-compliant component's look & feel, the MR has been reviewed by a UX designer.
  • If it changes GitLab UI's documentation guidelines, the MR has been reviewed by a Technical Writer.
  • If the MR changes a component's API, integration MR(s) have been opened (see integration merge requests above).
  • Added the ~"component:*" label(s) if applicable.

Accessibility

If this MR adds or modifies a component, take a few moments to review the following:

  • All actions and functionality can be done with a keyboard.
  • Links, buttons, and controls have a visible focus state.
  • All content is presented in text or with a text equivalent. For example, alt text for SVG, or aria-label for icons that have meaning or perform actions.
  • Changes in a component’s state are announced by a screen reader. For example, changing aria-expanded="false" to aria-expanded="true" when an accordion is expanded.
  • Color combinations have sufficient contrast.
Edited by Jeremy Elder

Merge request reports

Loading