Skip to content

Resolve "Remove unused components from vendored bootstrap-vue"

Vanessa Otto requested to merge 2752-remove-unused-components-from-vendored-bootstrap-vue into main

What does this MR do?

Remove (almost) all components in the vendored BootstrapVue folder which we don't use in our GL components. (Exception: icons. This MR is already huge, and the icons would make it massive. I'll open a new MR for those).

Reason: Primary goal is to migrate away from BootstrapVue. We could have started with migrating every single component step by step. But this will be a long process. I hoped that by throwing out all irrelevant files first, it reduces at least the mental workload. But it also reduces e.g. the tests which need to run in the bootstrap-vue, maybe some bundling time and in best case bundle sizes by throwing out some CSS.

Screenshots or screen recordings

Integration merge requests

N/A

Does this MR meet the acceptance criteria?

This checklist encourages the authors, reviewers, and maintainers of merge requests (MRs) to confirm changes were analyzed for conformity with the project's guidelines, security and accessibility.

Toggle the acceptance checklist

Conformity

  • Code review guidelines.
  • GitLab UI's contributing guidelines.
  • If it changes a Pajamas-compliant component's look & feel, the MR has been reviewed by a UX designer.
  • If it changes GitLab UI's documentation guidelines, the MR has been reviewed by a Technical Writer.
  • If the MR changes a component's API, integration MR(s) have been opened (see integration merge requests above).
  • Added the ~"component:*" label(s) if applicable.

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • Security reports checked/validated by a reviewer from the AppSec team

Accessibility

If this MR adds or modifies a component, take a few moments to review the following:

  • All actions and functionality can be done with a keyboard.
  • Links, buttons, and controls have a visible focus state.
  • All content is presented in text or with a text equivalent. For example, alt text for SVG, or aria-label for icons that have meaning or perform actions.
  • Changes in a component’s state are announced by a screen reader. For example, changing aria-expanded="false" to aria-expanded="true" when an accordion is expanded.
  • Color combinations have sufficient contrast.

Closes #2752 (closed)

Edited by Vanessa Otto

Merge request reports