Skip to content

feat(GlIcon): Add iconOpticallyAligned prop

Sascha Eggenberger requested to merge badge-add-mr-icons-to-circular-icons into main

What does this MR do?

This MR adds a new exposed prop iconOpticallyAligned to GlBadge. This prop can be used to optically align circular icons better with the badge (see screenshots below). We'll keep the currently defined icons for the issuable statues as legacy. Once we migrated them in the product, this can be refactored and removed. This way the consumer can defined how it should appear and we don't need to maintain an list of icons in GitLab UI.

In gitlab!168960 (comment 2157712229) we acknowledged it would be better to add this directly in GitLab UI.

Screenshots or screen recordings

Before After
before after

http://localhost:9001/?path=/story/base-badge--icon-optically-aligned

Integration merge requests

Does this MR meet the acceptance criteria?

This checklist encourages the authors, reviewers, and maintainers of merge requests (MRs) to confirm changes were analyzed for conformity with the project's guidelines, security and accessibility.

Toggle the acceptance checklist

Conformity

  • Code review guidelines.
  • GitLab UI's contributing guidelines.
  • If it changes a Pajamas-compliant component's look & feel, the MR has been reviewed by a UX designer.
  • If it changes GitLab UI's documentation guidelines, the MR has been reviewed by a Technical Writer.
  • If the MR changes a component's API, integration MR(s) have been opened (see integration merge requests above).
  • Added the ~"component:*" label(s) if applicable.

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • Security reports checked/validated by a reviewer from the AppSec team

Accessibility

If this MR adds or modifies a component, take a few moments to review the following:

  • All actions and functionality can be done with a keyboard.
  • Links, buttons, and controls have a visible focus state.
  • All content is presented in text or with a text equivalent. For example, alt text for SVG, or aria-label for icons that have meaning or perform actions.
  • Changes in a component’s state are announced by a screen reader. For example, changing aria-expanded="false" to aria-expanded="true" when an accordion is expanded.
  • Color combinations have sufficient contrast.

Related to gitlab#474922

Edited by Sascha Eggenberger

Merge request reports