Skip to content

Draft: Remove BFormInput from GlFormInput

Lorenz van Herwaarden requested to merge remove-bootstrap-vue-form-input into main

What does this MR do?

Closes #3036

The functionality of BFormInput is reimplemented directly in GlFormInput such that we don't need to import Bootstrap Vue's BFormInput anymore.

Some notes:

  • There should be no breaking changes. The only prop of BFormInput that is removed is no-wheel, but GlFormInput already set this value based on the input type so this should not be a breaking change.
  • The Bootstrap Vue tests are copied directly into the GlFormInput specs (same strategy as in Draft: Resolve "Remove `BFormSelect` from `GlFo... (!4899)). However, there are some adaptations, especially regarding the input and update events which are switched in GlFormInput.
  • The docs are copied from Bootstrap Vue's BFormInput docs but with some simplifications, like e.g. removing some simple examples.
  • The BFormInput, its specs, ... are not removed yet because there are other places that import BFormInput directly still.

Screenshots or screen recordings

Nothing visibly changed.

Integration merge requests

Does this MR meet the acceptance criteria?

This checklist encourages the authors, reviewers, and maintainers of merge requests (MRs) to confirm changes were analyzed for conformity with the project's guidelines, security and accessibility.

Toggle the acceptance checklist

Conformity

  • Code review guidelines.
  • GitLab UI's contributing guidelines.
  • If it changes a Pajamas-compliant component's look & feel, the MR has been reviewed by a UX designer.
  • If it changes GitLab UI's documentation guidelines, the MR has been reviewed by a Technical Writer.
  • If the MR changes a component's API, integration MR(s) have been opened (see integration merge requests above).
  • Added the ~"component:*" label(s) if applicable.

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • Security reports checked/validated by a reviewer from the AppSec team

Accessibility

If this MR adds or modifies a component, take a few moments to review the following:

  • All actions and functionality can be done with a keyboard.
  • Links, buttons, and controls have a visible focus state.
  • All content is presented in text or with a text equivalent. For example, alt text for SVG, or aria-label for icons that have meaning or perform actions.
  • Changes in a component’s state are announced by a screen reader. For example, changing aria-expanded="false" to aria-expanded="true" when an accordion is expanded.
  • Color combinations have sufficient contrast.
Edited by Lorenz van Herwaarden

Merge request reports