Skip to content

Decouple gitlab-ui $grid-size variable from gitlab

Enrique Alcántara requested to merge decouple-grid-size into master

This MR renames SCSS the $grid-size variable to $gl-grid-size. The purpose is to distinguish it from gitlab’s own grid-size variable. Since we decided to migrate all gitlab-ui variables to REM units, SCSS code in gitlab that is making calculations relying on the $grid-size variable and assuming that its value is defined in px units will fail to compile. This is evident on this MR: gitlab!16910 (merged)

To avoid this failure, this MR stops overwriting spacing variables, and rename $grid-size to avoid overwriting gitlab’s own $grid-size.

Merge request reports