fix(toggle): pass a Number as the icon's size property (!880) · Merge requests · GitLab.org / gitlab-ui

Paul Gascou-Vaillancourt requested to merge fix-toggle-icon into master Oct 31, 2019

When trying to upgrade @gitlab/ui in GitLab, spec/frontend/vue_shared/components/gl_toggle_vuex_spec.js started failing because the Toggle component passes the size property as a String instead of a Number to the underlying Icon component.

This MR fixes this and adds a new specs file to test this particular error.

NOTE: I tested this change in GitLab and can confirm that the Jest spec passes properly.

Edited Oct 31, 2019 by Paul Gascou-Vaillancourt

fix(toggle): pass a Number as the icon's size property

Merge request reports