Skip to content

fix(banner): address GitLab integration issues

Paul Gascou-Vaillancourt requested to merge remove-gitlab-css/fix-gitlab-integration-issues-banner into master

This MR fixes GitLab integration issues in the Banner component. Specifically:

  • The margins on the title had to be set explicitly
  • The new-button component was used instead of the button component to ensure that we use a Pajamas-compliant button that looks the same with and without GitLab's CSS
  • The <a> tag in one of the stories has been replaced with a gl-link component and a link.scss with the minimum styles for links has been created so that gl-link looks consistant in stories
Before After
image image
Edited by Paul Gascou-Vaillancourt

Merge request reports