Skip to content

ci(commit-lint): include merge and revert commits in linting

Tomas Vik requested to merge update-commit-lint into main

I've noticed that !144 (merged) didn't have a valid commit message, but the lint_commmit CI Job didn't fail.

After some investigation, I found out that the commit-lint library considers Revert and Merge commits valid by default.

We only run the lining on MRs (not on the main branch) and so we don't need to allow revert and merge commit messages. On the other hand, we must ensure that the MR produces a conventional commit message so we don't have to manually craft the changelog.

Scenario that we are fixing:

The following log on !144 (merged) contains multiline messages and so the first message is used when we squash the MR. The Revert "Replace all backslashes in file paths with forward slashes" is used and the linting doesn't fail. That message doesn't produce a changelog entry.

commit 48ce110b693cdcf6cd21b88ac62ffe33c4f0396d
Author: Eli E <>
Date:   Mon Dec 14 10:52:22 2020 -0500

    Replace backslashes with forward slashes after decode
    
    Right after the path is decoded, replace any backslashes with forward slashes

commit 82183b4011aa9fb8e446fce0986a4aaf7a48abc4
Author: Eli E <>
Date:   Sat Dec 12 13:10:08 2020 -0500

    Revert "Replace all backslashes in file paths with forward slashes"
    
    This reverts commit 2dfb3c3d460b86a6f619f4610691aae2a8cc50d6.

commit 2dfb3c3d460b86a6f619f4610691aae2a8cc50d6
Author: Eli E <>
Date:   Sat Dec 12 13:10:08 2020 -0500

    Replace all backslashes in file paths with forward slashes
Edited by Tomas Vik

Merge request reports