Skip to content

fix(Duo Chat): Remove clean slash command

Dylan Bernardi requested to merge db/remove-clean-slash-command into main

This is an integration branch for:

Description

This MR upgrades gitlabUI to 96.0.0.

This MR removes the /clean slash command for GitLab versions of 17.5.0 and greater. The MR renamed all instances of cleanChat to clearChat for consistency.

As a method of version control, the MR includes a logic check the GitLab version that is being used in the extension.

  1. If the /clean command is sent and the version is before 17.5.0, the clearChat function will execute.
  2. If the /clean command is sent and the version is later than 17.5.0, the /clean input is sent just like any other prompt

Resolves [VS Code] FY25 Bug Bounty, Duo Chat /clean Bug (#1434 - closed)

How has this been tested?

To test this, you'll need the GDK set up and a license to use Duo Chat in the GDK. If these are both true, then do the following:

  1. Start your gdk and create a PAT with the api_scope
  2. Open VSCode and go to Deauth your current gitlab account from the drop down menu: GitLab: Remove Account from VS Code
  3. Re-connect account from drop down menu: GitLab: Authenticate
  4. Select Manually enter instance URL and enter http://127.0.0.1:3000
  5. Input the PAT token created in step 1
  6. Checkout this branch and run the plugin.
  7. Manually change the version to 17.7.0 and beyond to test backwards compatibility
  8. Manually change the version to 17.2.0 and before to test updated behavior

If you do not have the GDK set up, I have done the steps above and created videos for you (I am also happy to demo live if need be):

Clean Removed Backwards Comptabile
removeClean_vsCode_newMonolith removeClean_vsCode_backwardsCompatabile

What CHANGELOG entry will this MR create?

  • fix: Bug fix fixes - a user-facing issue in production - included in changelog
  • feature: New feature - a user-facing change which adds functionality - included in changelog
  • BREAKING CHANGE: (fix or feature that would cause existing functionality to change) - should bump major version, mentioned in the changelog
  • None - other non-user-facing changes
Edited by Dylan Bernardi

Merge request reports