Skip to content

chore: ensure child watchers always stop

Elwyn Benson requested to merge 1648-killing-watch-desktop-uncleanly-leaves-child-watchers-running into main

Description

Fixes issue with watch:desktop script, where if the main process is killed un-cleanly, (e.g. via SIGINT), the child watch processes (such as watchWebviews) could continue to run orphaned in the background.

Demo of problem

Note how the webview watcher is still responding to changes after I kill watch:desktop when switching branches or npm installing

child-watch-in-background

I'm unsure if others run into this, but it frequently happens for me (maybe it's to do with running on linux / my shell / ???)

Related Issues

Resolves #1648

What CHANGELOG entry will this MR create?

  • fix: Bug fix fixes - a user-facing issue in production - included in changelog
  • feature: New feature - a user-facing change which adds functionality - included in changelog
  • BREAKING CHANGE: (fix or feature that would cause existing functionality to change) - should bump major version, mentioned in the changelog
  • None - other non-user-facing changes

Closes #1648

Edited by Elwyn Benson

Merge request reports